Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow errors in TCP.start_protocol/1 pipeline to be returned. #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lmarlow
Copy link

@lmarlow lmarlow commented Oct 13, 2017

When connecting many clients to an XMPP server quickly, closed streams
can occur. Let those errors through instead of blowing up due to
FunctionClauseError.

This could probably be done more cleanly with with, but mix.exs specifies compatibility back to Elixir 1.1.

Fixes #27

When connecting many clients to an XMPP server quickly, closed streams
can occur. Let those errors through instead of blowing up due to
FunctionClauseError.

Fixes scrogson#27
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.3%) to 71.885% when pulling 01a3bc5 on lmarlow:send_error into 0ecef1e on scrogson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 75.399% when pulling 84a4fe7 on lmarlow:send_error into 0ecef1e on scrogson:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not handling possible error when calling :gen_tcp.send/2 in Romeo.Transports.TCP.send/2
2 participants