Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the keyboard able to replace currency symbols #492

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

vickcoo
Copy link
Contributor

@vickcoo vickcoo commented Aug 22, 2024

the iPhone keyboard could be replaced with difference currency symbols

Contributor checklist


Description

In this task, modify the keyboard generation from static to dynamic using the builder pattern which allows the keyboard to replace currency symbols (also can replace other symbols).

Related issue

the iPhone keyboard could be replaced with difference currency symbols
Copy link

github-actions bot commented Aug 22, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 22, 2024 20:49
@andrewtavis
Copy link
Member

Hey @vickcoo! This is really great! 🚀 Seems like a really great way to go about this :) You'd be very welcome to update each of the language keyboard interface files with this method of building the keyboards. Remember that we also need to do the same for genPadNumberKeys and genPadSymbolKeys as well 😊

Thanks so much for getting to this so quickly and bringing such a great improvement to the project! 🙌

@vickcoo
Copy link
Contributor Author

vickcoo commented Aug 24, 2024

Hi @andrewtavis, thanks for reminding me about the modification I missed, I've also finished the keyboards for each language.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some great progress here, @vickcoo! My recent commit made the needed adjustments to the keyboards that we're working on, but aren't launched yet :)

Thanks so much for the ideation of the issue and for the great implementation! 🚀🙏

@andrewtavis andrewtavis merged commit 6e72d7f into scribe-org:main Aug 24, 2024
1 check passed
@vickcoo vickcoo deleted the currency-symbol-selection branch August 24, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants