-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the keyboard able to replace currency symbols #492
Make the keyboard able to replace currency symbols #492
Conversation
the iPhone keyboard could be replaced with difference currency symbols
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Hey @vickcoo! This is really great! 🚀 Seems like a really great way to go about this :) You'd be very welcome to update each of the language keyboard interface files with this method of building the keyboards. Remember that we also need to do the same for Thanks so much for getting to this so quickly and bringing such a great improvement to the project! 🙌 |
Hi @andrewtavis, thanks for reminding me about the modification I missed, I've also finished the keyboards for each language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some great progress here, @vickcoo! My recent commit made the needed adjustments to the keyboards that we're working on, but aren't launched yet :)
Thanks so much for the ideation of the issue and for the great implementation! 🚀🙏
the iPhone keyboard could be replaced with difference currency symbols
Contributor checklist
Description
In this task, modify the keyboard generation from static to dynamic using the builder pattern which allows the keyboard to replace currency symbols (also can replace other symbols).
Related issue