Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in the small divider line between About options and Settings options without a description #139

Open
2 tasks done
angrezichatterbox opened this issue Sep 22, 2024 · 7 comments · May be fixed by #180
Open
2 tasks done

Add in the small divider line between About options and Settings options without a description #139

angrezichatterbox opened this issue Sep 22, 2024 · 7 comments · May be fixed by #180
Assignees
@MostafaMohamed2002
Labels
design Relates to UX/UI designs feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@angrezichatterbox
Copy link
Collaborator

Terms

Description

In Scribe-iOS there is a small line that separates the different items in the Table View when there is no description. This can be seen in the image given below.

Screenshot 2024-09-22 at 10 54 54 AM

Currently, Scribe-Android does not separate the items in the Recycler View using a line when there is no description. This issue aims to add a line between items in a recycler view when there is no description.

Screenshot 2024-09-22 at 10 56 36 AM

Contribution

I would love to work on this and am more than willing to help anyone fix this issue :)
@angrezichatterbox angrezichatterbox added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed design Relates to UX/UI designs labels Sep 22, 2024
@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Sep 30, 2024
@MostafaMohamed2002
Copy link
Contributor

can you assign this to me ?

@angrezichatterbox
Copy link
Collaborator Author

Feel free to work on this issue. In case of doubts don't hesitate to ask us. Thanks :)

@MostafaMohamed2002
Copy link
Contributor

MostafaMohamed2002 commented Oct 7, 2024 •
edited
Loading

is this screenshot from settings fragment , after installing the keyboard ? @angrezichatterbox @andrewtavis
image

@andrewtavis
Copy link
Member

andrewtavis commented Oct 7, 2024 •
edited
Loading

That or the language of the application, @MostafaMohamed2002 :) Each should have a divider.

@MostafaMohamed2002
Copy link
Contributor

should i make a pull request ?🤨 @andrewtavis @angrezichatterbox
image image

@andrewtavis
Copy link
Member

I'm kind of assuming that the differences in the pixel heights are maybe from the emulator, @MostafaMohamed2002? Aside from this, what's the color? If it's the text color, then it'd be great if it'd be the special text color that we use for the icon :) Can't tell exactly from the images.

@MostafaMohamed2002
Copy link
Contributor

i will open a pr so we can dicuss more clearly

MostafaMohamed2002 added a commit to MostafaMohamed2002/Scribe-Android that referenced this issue Oct 9, 2024
@MostafaMohamed2002
Refactor RecyclerView item decoration in AboutFragment and SettingsFr…
240bfc9 
…agment

- Extracted the custom RecyclerView item decoration logic into a separate class called CustomDividerItemDecoration.
- Added the CustomDividerItemDecoration to the RecyclerViews in AboutFragment and SettingsFragment.
- Applied a custom drawable as the divider with a width of 1dp and rounded corners.
- Set the left and right margins of the dividers to 50dp.

Fixes scribe-org#139
@MostafaMohamed2002 MostafaMohamed2002 linked a pull request Oct 9, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MostafaMohamed2002 MostafaMohamed2002

Labels
design Relates to UX/UI designs feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Scribe Board
Status: In Progress
Milestone
No milestone
3 participants
@andrewtavis @MostafaMohamed2002 @angrezichatterbox