Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotation] Style first autosuggestion button based on the gender of a word typed #135

Open
2 tasks done
andrewtavis opened this issue Sep 21, 2024 · 5 comments
Open
2 tasks done
Labels
blocked Another issue is blocking feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Sep 21, 2024

Terms

Description

This issue is the first to start adding in Scribe command functionality to Scribe-Android 🚀

When a user types a word that is found in a nouns table we'd like the first autosuggestion button to change based on the gender of the word. The suggestion key should also be disabled when an annotation is being shown.

The changes are the following:

  • For feminine the key is red with an F
  • For masculine the key is blue with an M
  • For neutral the key is green with an N
  • For common (combination of feminine and masculine in Swedish) the key is purple with a C
  • For plural the key is orange with a PL

The letters described above should also change based on the language. See Scribe-iOS/Keyboards/KeyboardsBase/ScribeFunctionality/Annotate.swift#L37 for the needed conversions for Swedish and Russian.

Contribution

Happy to support with this and get to it myself eventually if need be! This is the first Scribe functionality within Scribe-Android. Really looking forward to it 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed blocked Another issue is blocking labels Sep 21, 2024
@ZayJackPrvy
Copy link

Hi @andrewtavis . I'd like to work on this issue. Could you please assign it to me?

@andrewtavis
Copy link
Member Author

Hey @ZayJackPrvy 👋 Appreciate your interest in working with us! This issue's currently blocked a few issues in our data ingestion application. You'd be welcome to work on it after, which should be in a few weeks :) Is there another one you'd be interested in in that time?

@ZayJackPrvy
Copy link

@andrewtavis Yes. I would like to work on an issue that’s not too trivial, such as simple text changes or button adjustments. Could you recommend an appropriate issue for me? It's part of university course to contribute to an open-source project, and I’ve chosen your project. Hopefully it's OK for you.

@andrewtavis
Copy link
Member Author

100% ok, @ZayJackPrvy! Thanks for letting me know as it's important for me to be able to provide the attention you'd need for it :) Can you tell me what the deadline is so I can keep it in mind? I'll look for some suggestions 😊

@ZayJackPrvy
Copy link

ZayJackPrvy commented Oct 1, 2024

@andrewtavis The deadline for the issue selection is until next week, but I can work on it much longer if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another issue is blocking feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants