-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CaptureController an EventTarget #9
Comments
Are you aware of precedents of an extension spec introducing inheritance? |
@eladalon1983 For now the solutions I have in mind are:
|
Short-term, let's redefine CaptureController in our spec as inheriting from EventTarget. (That is, not use Long-term, let's try to get this accepted in the Screen Capture spec. I'll start the discussion. (Edit: I've filed w3c/mediacapture-screen-share/issues/268 and w3c/mediacapture-screen-share/issues/269 and asked for a time slot to discuss this during the June interim of the WebRTC WG, which manages the spec where CaptureController is defined.) |
- Make CaptureController an EventTarget (screen-share#9), temporarily redefining it until this is done in the "Screen Capture" spec. Also align the way oncapturedmousechange is specified with similar EventHandler attributes from the "Media Capture and Streams" spec (i.e. by referring to an event type). - Elaborate in the CapturedMouseEvent section the way events are dispatched on CaptureController objects associated to a capture-session, defining a new capturedmousechange type for them. Also move there the requirements about when to fire the event.
- Make CaptureController an EventTarget (screen-share#9), temporarily redefining it until this is done in the "Screen Capture" spec. Also align the way oncapturedmousechange is specified with similar EventHandler attributes from the "Media Capture and Streams" spec (i.e. by referring to an event type). - Elaborate in the CapturedMouseEvent section the way events are dispatched on CaptureController objects associated to a capture-session, defining a new capturedmousechange type for them. Also move there the requirements about when to fire the event.
@eladalon1983 OK, I submitted a first PR here: #10 ; will work on the constructor stuff in a separate PR |
- Make CaptureController an EventTarget (screen-share#9), temporarily redefining it until this is done in the "Screen Capture" spec. Also align the way oncapturedmousechange is specified with similar EventHandler attributes from the "Media Capture and Streams" spec (i.e. by referring to an event type). - Elaborate in the CapturedMouseEvent section the way events are dispatched on CaptureController objects associated to a capture-session, defining a new capturedmousechange type for them. Also move there the requirements about when to fire the event.
Frédéric, do you mind if I close this issue now? |
@eladalon1983 OK when #10 is merged :-) and then we can close issue #1 too |
Oh nevermind, we actually don't need to specify inheritance on partial interfaces. I already had removed that from PR #10... |
See https://dom.spec.whatwg.org/#eventtarget
The extension in the spec is:
I see interfaces with similar interfaces with similar
onsomething
EventHandler attribute derive fromEventTarget
but not sure whether that's something that is a requirement or even just that we consider interesting here.The text was updated successfully, but these errors were encountered: