Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

fix .modal.fade position #471

Merged
merged 1 commit into from
Jul 30, 2021
Merged

fix .modal.fade position #471

merged 1 commit into from
Jul 30, 2021

Conversation

yueyuzhao
Copy link
Contributor

@yueyuzhao yueyuzhao commented Jul 21, 2021 •
edited
Loading

Resolves

Proposed Changes

remove .modal.fade top attribute

Reason for Changes

useless and causes the .modal.fade div out of the screen

Test Coverage

  • iPad mini 2 (iOS 12.5.2)
  • Fire HD 8 (2017) (Android 5)
  • JD Tablet (Android 6.0)

@yueyuzhao yueyuzhao marked this pull request as ready for review July 21, 2021 12:37
chrisgarrity
chrisgarrity approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chrisgarrity chrisgarrity merged commit f35659d into scratchfoundation:develop Jul 30, 2021
@yueyuzhao yueyuzhao deleted the issue/454-loading-animation branch July 31, 2021 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisgarrity chrisgarrity chrisgarrity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading animation is missing for story starters
2 participants
@yueyuzhao @chrisgarrity