Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

'Start on Bump' block doesn't re-activate after a stop block #120

Open
chrisgarrity opened this issue Mar 3, 2017 · 5 comments
Open

'Start on Bump' block doesn't re-activate after a stop block #120

chrisgarrity opened this issue Mar 3, 2017 · 5 comments
Assignees
Milestone

Comments

@chrisgarrity
Copy link
Contributor

In the following program, the purple character continuously falls from the top, and says 'tac' if touching the cat.

The cat moves across the screen, saying 'meow' when touching Tac, after 5 seconds, run the stop block and say stop. Once the cat is stopped, the 'Start on Bump' block is deactivated, so even though Tac detects collision, the cat doesn't.

img_0023

This is the screen after stop with the sprites touching. Tac has a say bubble, but the cat doesn't.
img_0024

This came from a project where there were arrows to control the direction of the cat that sent messages. When a message arrived the cat would stop and start going in the direction of the arrow.

@thisandagain thisandagain added this to the April 19 milestone Mar 6, 2017
@thisandagain thisandagain self-assigned this Mar 6, 2017
@thisandagain thisandagain modified the milestones: Backlog, April 19 Mar 28, 2017
@thisandagain thisandagain removed their assignment May 22, 2017
@Petroochio
Copy link

@chrisgarrity @thisandagain Quick question about the expected functionality here. When the stop block is executed should it:
A) stop all block threads
B) stop only the one the stop block is in
C) stop all the ones that start with a flag
D) stop all running threads, then restart all of the ones that start with a trigger rather than the flag
Or something else entirely.

From what I can see is that when the stop command is executed it always stops all threads on the sprite it is targeted at. To fix this we would need to add a special case to make the threads that should continue running, or add some logic for restarting specific threads in this case... This question didn't turn out to be so quick.

I'd like to take a stab at this, but I'm unclear on the direction I should go.

@chrisgarrity
Copy link
Contributor Author

@Petroochio thanks for the question. The expectation is D. All the running scripts for this character will stop running, but stacks that start with a trigger can be restarted if the trigger occurs. This appears to be a bug with just the bump block. If you change the start on bump block on the cat to start on tap, then the cat says 'meow' when you tap it both before and after the stop.

@deepankarmalhan
Copy link
Contributor

@chrisgarrity will check if this is still an issue, if needed we will make a Jira ticket.

@chrisgarrity
Copy link
Contributor Author

@deepankarmalhan confirmed that it's still an issue.
One extra note, I added a START ON TAP -> play pop strip.

After the stop block the start on bump doesn't trigger.
When the cat is tapped, the START ON TAP is triggered (the pop sounds), and the START ON BUMP starts triggering again.

@deepankarmalhan
Copy link
Contributor

@delasare let's see if this is still an issue in redesign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants