Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawable's rotation is not 0 when the drawable is not rotated #688

Open
fsih opened this issue Aug 27, 2020 · 1 comment
Open

Drawable's rotation is not 0 when the drawable is not rotated #688

fsih opened this issue Aug 27, 2020 · 1 comment

Comments

@fsih
Copy link
Contributor

fsih commented Aug 27, 2020

Expected Behavior

The drawable's rotation should be 0 by default

Actual Behavior

The stage, shouldn't be able to be moved, scaled, or rotated in any way. Its matrix should be the identity, and hence its inverse matrix should be the identity. However, you can see here that some of the entries that are supposed to be 0 are as large as -.002, which is a pretty high error.
Screen Shot 2020-08-13 at 00 31 13

Here's another time where I ran it on the same machine, but the results were different 🤔
Screen Shot 2020-08-27 at 16 41 24

The result of this is that calculations are slightly wrong. For instance, here, the localPosition[0] calculation should come out to 0, but it's negative, which caused the touching white issue here: #676 (comment)
Screen Shot 2020-08-13 at 00 29 05

Having a 1e-6 error margin is kind of large and feels rather hacky at ffa53a6, so ideally we would fix the underlying math

Steps to Reproduce

Check drawable._inverseMatrix on the stage and see that it's not the identity

Operating System and Browser

any

@BryceLTaylor
Copy link

@fsih What is the user facing problem with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants