Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Led component #1

Open
lastmjs opened this issue Nov 4, 2016 · 2 comments
Open

Led component #1

lastmjs opened this issue Nov 4, 2016 · 2 comments
Assignees
@bdemann
Milestone
Before the articl...

Comments

@lastmjs
Copy link
Member

lastmjs commented Nov 4, 2016

No description provided.

@lastmjs lastmjs added this to the Prototype milestone Nov 4, 2016
@lastmjs lastmjs changed the title Create led component Led component Apr 22, 2017
@bdemann
Copy link
Member

bdemann commented Jun 6, 2017 •
edited
Loading

I was reading through the LED documentation and it says that the pin value can be "a Number or String address for the Led pin (digital/PWM)." If it takes either a number or a string we shouldn't have to check what the user is giving us we can just put it into the jfive API? @lastmjs or should we be checking that input? Or any of the input? In other words how much responsibility is on us for correct input into the attributes?

@lastmjs
Copy link
Member Author

lastmjs commented Jun 6, 2017

I don't think we should check the input, just pass it along. If they mess it up it will break, but they need to ensure they don't do that. It's the defensive programming versus not debate, and I think we shouldn't be too defensive in this case, just to keep it simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdemann bdemann

Labels
None yet
Projects
None yet
Milestone
Before the article is released
Development

No branches or pull requests
2 participants
@lastmjs @bdemann