Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International System of Units -> Km (not Miles) #20

Open
Jerome-Liger opened this issue Jan 24, 2022 · 1 comment
Open

International System of Units -> Km (not Miles) #20

Jerome-Liger opened this issue Jan 24, 2022 · 1 comment

Comments

@Jerome-Liger
Copy link

Why american's developers only calculate distance with miles and never think about all the rest of the "standardized-world-developers" ?

Please, use the ISU (International System of Units) by default... it has been released in 1960... so any length must be expressed in meters (or cm/Km/...)

https://en.wikipedia.org/wiki/International_System_of_Units

And if you want to add an overload/option to get the result on miles, I'm not against ;-)
(For example, MAUI Location Extension ask the unit (Km or Miles) in parameter : https://www.andreasnesheim.no/calculating-distance-between-your-device-and-a-location-with-net-maui/)

Some rockets have already exploded in the past for this kind of imperial units problems... with unfortunate human deaths.

@madelson
Copy link

madelson commented Aug 19, 2023

I think DistanceUnit should be a required parameter. If I just see GeoCalculator.GetDistance(a, b), it is not clear what that distance is measured in (meters? km?).

Furthermore, Changing the default DistanceUnit from Miles to Meters/Kilometers should come with a major version bump since just upgrading would break anyone using the default without their knowing it. However, removing the default would only be a source-level break so this would not require a major bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants