Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlertMedia AutoMock repo #34

Open
JoenyBui opened this issue Mar 31, 2021 · 5 comments
Open

AlertMedia AutoMock repo #34

JoenyBui opened this issue Mar 31, 2021 · 5 comments

Comments

@JoenyBui
Copy link

JoenyBui commented Mar 31, 2021

Hi,

I'm working for AlertMedia and we are making some improvements on the automocker and such (https://github.com/alertmedia/cypress-auto-mock). We were wondering if you were open to having us merge our changes to your branch so we can help maintain it. Our changeset deviates quite a bit, so we'll likely need to refactor to get it working wit yours.

A couple of bugs fix and changes are:

  • Add responseHeaders to the code (so we can use HEAD request)
  • Added params for GET and HEAD request as a way to match keys
  • Add more verbose logging
  • We added functions at the global level so on our App can add stuff to the apiMockLists and such. (We integrate the ability t mock cy.request)
  • Fix some bugs
  • Update some tests

Let us know what your thoughts are. We are heavily invested in automock so we want to make sure that we can help maintain in any way possible.

Joeny

@scottschafer
Copy link
Owner

scottschafer commented Mar 31, 2021 via email

@JoenyBui
Copy link
Author

JoenyBui commented Apr 1, 2021

Scott,

Cool, let me talk with my team and see who we can sucker into volunteering. I just want to clarify, would you still be interested in maintaining this repo.

Also, I will take a look at cypressautomockerV2 and see if will work even better for us. I hadn't said this yet but really appreciate you putting this thing all together.

Joeny

@JoenyBui
Copy link
Author

JoenyBui commented Apr 1, 2021

Looks like the big change is the xhook package.

@scottschafer
Copy link
Owner

scottschafer commented Apr 1, 2021 via email

@JoenyBui
Copy link
Author

JoenyBui commented Apr 1, 2021

That's fascinating. I had similar ideas when I was deep-diving into the code about this but your information gives me a bit to ponder about. I guess for now you can put me as a maintainer. I was wondering if we can just put some of the v2 stuff in a different file in this repo so it won't break backward compatibility but have it readily available so people could transition over if it suits them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants