Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage Noise #126

Open
mbillingr opened this issue Feb 12, 2016 · 2 comments
Open

Coverage Noise #126

mbillingr opened this issue Feb 12, 2016 · 2 comments

Comments

@mbillingr
Copy link
Member

Coverage increases and decreases between builds by +/- 13 lines in _infomax.py. I've tracked this down to the if wts_blowup: code branch. Sometimes the weights blow up and we get these 13 lines, and somitemes they don't and we miss those lines.

Maybe we did not random-seed all the tests yet? Or does Infomax ignore our seeds?

Also, I noticed that all code branches related to Extended Infomax are untested. Haven't we changed the default to use extended, or did we just discuss this?

@cbrnr
Copy link
Contributor

cbrnr commented Feb 12, 2016

We only discussed changing to Extended Infomax in #53. There were still a couple of open questions.

Infomax does have a seed argument, so it shouldn't ignore it if we set it. It's more likely we've not seeded all examples.

@mbillingr
Copy link
Member Author

I have never seeded Infomax in particular. The tests only set the seed of the global numpy random engine.

At least one test does not set the seed: TestMVARICA.testModelIdentification() in test_varica.py. There may be more, still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants