Reforged update 02 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provided support for two input formats for the ReforgedPlayerMetadata class.
Add new news file with changes
One of the byte readers in the ReforgedPlayerMetadata class skipped reading in the portrait ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new reader for the ReforgedPlayerMetadata class that should allow for reading more replays from Warcraft III Reforged. Unfortunately, there doesn't seem to be a good way to tell which reader to use for it, so I just try one and then if it fails it tries the other. It looks like there are some new GAME_TYPES being used, maybe if we had more different types of replays that would tell us.
I also added the BNet portrait ID as a property of the ReforgedPlayerMetadata class. I don't have a mapping to know which portrait ID maps to which portrait, but if we figure that out later it can be added.
Closes #16