Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instances of abort(500) or raise HTTPInternalServerError #470

Closed
coltonlw opened this issue Sep 6, 2016 · 0 comments
Closed

Remove instances of abort(500) or raise HTTPInternalServerError #470

coltonlw opened this issue Sep 6, 2016 · 0 comments

Comments

@coltonlw
Copy link
Contributor

coltonlw commented Sep 6, 2016

We should remove code paths in which we intentionally return a 500 status code, since this is never a desirable situation. If there really is an internal error related to the semantics of our application, a non-http exception should be raised, because the webapp2 500 error handler is only called when the exception does not inherit from HTTPException. This ensures our custom error handling / logging code is called
See #451

@gsfr gsfr closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants