Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Filenames with slashes #1071

Closed
hkethi002 opened this issue Feb 7, 2018 · 4 comments
Closed

Allow Filenames with slashes #1071

hkethi002 opened this issue Feb 7, 2018 · 4 comments
Assignees

Comments

@hkethi002
Copy link
Contributor

Currently slashes are removed on file upload, we should allow for filenames with slashes, and simply allow it to be a part of the download path.

@kofalt
Copy link
Contributor

kofalt commented Feb 16, 2018

I believe this would break our client, which assumes a slash is a directory separator. Are you sure we cannot continue stripping them? Slashes are not a part of a healthy filename.

@nagem
Copy link
Contributor

nagem commented Feb 16, 2018

There were requests to see what changes would be required to store slashes as part of a Mongo object's filename so it could be maintained on download and clients could display the additional path information. This PR is currently a holding ground for @hkethi002 exploratory work.

@kofalt
Copy link
Contributor

kofalt commented Feb 16, 2018

Ah, I see you are referencing #1077 👍

@nagem
Copy link
Contributor

nagem commented Feb 16, 2018

Exactly, didn't realize we were in the issue not the PR.

@gsfr gsfr closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants