-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the generic instrument_view
be removed?
#523
Comments
For the record, a discussion on Slack about the usefulness of being able to display additional beamline components: Neil Vaytet Gregory Tucker
Neil Vaytet Gregory Tucker Neil Vaytet Gregory Tucker |
Should the
instrument_view
be removed altogether? I see it's use could be quite limited if we are adding instrument-specific versions in the other packages (e.g.dream.instrument_view
).There is almost nothing in the instrument view compared to using Plopp's
scatter3d
directly, apart from the additional beamline components that can be shown, but experience has shown that this is basically unused.There is an additional maintenance burden of keeping both
scatter3d
andinstrument_view
. See #484 for example.See also #452
The text was updated successfully, but these errors were encountered: