Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absorption correction for cylindrical samples #22

Open
celinedurniak opened this issue Feb 14, 2024 · 3 comments · Fixed by scipp/scippneutron#532 · May be fixed by #104
Open

Absorption correction for cylindrical samples #22

celinedurniak opened this issue Feb 14, 2024 · 3 comments · Fixed by scipp/scippneutron#532 · May be fixed by #104

Comments

@celinedurniak
Copy link
Collaborator

Executive summary

Calculate and apply absorption correction for cylindrical samples in Powder Diffraction

Context and background knowledge

For example, see algorithms in Mantid

AbsorptionCorrection

CylinderAbsorption

SNSPowderReduction in Mantid to check when the absorption correction is applied within the whole workflow

Inputs

Scipp data structure from loaded NeXus or csv file(s)

Assumption: the input should be expressed in wavelength

Note that information about the sample (chemical formula, geometry, mass density, number density...) might be stored in the sample log of the file or must have to be provided by the user when using the algorithm.

Methodology

See source code from (Mantid) references above

Assumption: we consider only cylindrical samples for this first implementation

Acceptance criterion
Absorption correction step is implemented in ESS Diffraction worflow (https://scipp.github.io/ess/instruments/external/powgen/powgen.html)

Outputs

This requirement should provide the absorption correction term and the corrected sample data

Which interfaces are required?

Integrated into reduction workflow, Python module / function

Test cases

  • As input file, use POWGEN event file provided in Mantid (PG3_4866_event.nxs or PG3_4844_event.nxs) and already used in ESS Diffraction workflow.
    In this case, the output from the implementation in Scipp could be compared with what we get from Mantid.
  • CSV files from DREAM (also available in Scipp documentation)

Comments

Followup Work: Extend this implementation to:

  • other sample shapes
  • several components (sample, container)
  • using other assumptions (like ‘FullPaalmanPings’)
@SimonHeybrock SimonHeybrock changed the title DREAM - Absorption correction for cylindrical samples Absorption correction for cylindrical samples Feb 14, 2024
@SimonHeybrock
Copy link
Member

Before implementing, we should consider if the actual correction should be part of ScippNeutron, since it is very generic. ESSdiffraction would then only contain the workflow integration, imported from ScippNeutron.

@celinedurniak celinedurniak changed the title Absorption correction for cylindrical samples [Requirement] Absorption correction for cylindrical samples Feb 15, 2024
@celinedurniak celinedurniak changed the title [Requirement] Absorption correction for cylindrical samples Absorption correction for cylindrical samples Feb 15, 2024
@SimonHeybrock SimonHeybrock added this to the Essentials milestone Feb 26, 2024
@jl-wynen jl-wynen removed this from the Powder Essentials milestone Mar 7, 2024
@jl-wynen
Copy link
Member

jl-wynen commented Mar 7, 2024

Removed from essentials milestone because it is unclear whether this should be done during reduction or analysis. Postponing implementation until we have clarity.

@jl-wynen jl-wynen removed the status in Development Board Mar 7, 2024
@SimonHeybrock SimonHeybrock moved this from Triage to Selected in Development Board Jul 10, 2024
@jokasimr jokasimr self-assigned this Jul 24, 2024
@jokasimr jokasimr moved this from Selected to In progress in Development Board Jul 26, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Board Nov 7, 2024
@jokasimr jokasimr reopened this Nov 7, 2024
@jokasimr
Copy link
Contributor

jokasimr commented Nov 7, 2024

Still needs to apply correction in diffraction workflow

@jokasimr jokasimr linked a pull request Nov 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants