Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda-verify? #41

Open
SimonHeybrock opened this issue Oct 16, 2023 · 2 comments
Open

Use conda-verify? #41

SimonHeybrock opened this issue Oct 16, 2023 · 2 comments

Comments

@SimonHeybrock
Copy link
Member

We have this warning in package builds:

Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.

Should we fix that?

@jl-wynen
Copy link
Member

Sure, let's try it out!

@jl-wynen
Copy link
Member

Tried it and it emits a single warning:

/tmp/tmpnf0srwsm/proj-23.11.0-py_0.tar.bz2: C1115 Found invalid license "BSD-3-Clause" in info/index.json

According to https://github.com/conda/conda-verify/blob/3b34286470dd1ceb495374e3ff7b52082084da8e/conda_verify/constants.py#L8 it only wants "BSD" as the license. But in practice we haven't encountered any problems with this. So I don't know if we should change it.

In any case, I tried changing it and the warning went away. I also added license_file in my test like this: (in meta.yaml)

about:
  home: https://github.com/scipp/proj
  license: BSD
  license_file: LICENSE
  summary: testing
  description: testing
  dev_url: https://github.com/scipp/proj
  doc_url: https://scipp.github.io/proj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants