Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scipp and ess specifics #196

Open
jokasimr opened this issue Jul 22, 2024 · 0 comments
Open

Remove scipp and ess specifics #196

jokasimr opened this issue Jul 22, 2024 · 0 comments

Comments

@jokasimr
Copy link
Contributor

jokasimr commented Jul 22, 2024

Recently some ess specifics were re-added to the repo, see scipp/scippneutron#476 and #192 (comment).

We would like to move those specifics to https://github.com/scipp/ess_template if possible, or at least only include them conditionally, if the repo is a scipp- repo or an ess- repo.

One solution would be to make the workflows jinja templates, and make them render the environment variable settings only if the repo is a scipp repo. However, there are some issues with using templates because they are not picked up well by github bots (please correct / clarify this).

@jokasimr jokasimr changed the title Remove scipp and workflow specifics Remove scipp and ess specifics Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant