Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scippneutron needs mantid for building docs and tests #173

Open
MridulS opened this issue Apr 29, 2024 · 2 comments
Open

scippneutron needs mantid for building docs and tests #173

MridulS opened this issue Apr 29, 2024 · 2 comments

Comments

@MridulS
Copy link
Member

MridulS commented Apr 29, 2024

The logic should be moved to the template here so copier update doesn't mess up scippneutron downstream

@YooSunYoung
Copy link
Member

I thought it'll create a conflict when the related part is updated from the copier,
if a file is updated after copier-(copy/update).
We should just check the diff file by file after copier update, before we commit the changes...?

I think we don't want to include every cases in the copier-template
and using mantid in the scippneutron is one of the special cases, no...?

@SimonHeybrock
Copy link
Member

Agree with @YooSunYoung. As far as I have seen conflicts usually happen only "once", and if they are resolved correctly then subsequent updates (that do not further change the specific code location) work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants