Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinned tox test environment uses the last release of the project itself. #159

Open
MridulS opened this issue Apr 18, 2024 · 4 comments
Open

Comments

@MridulS
Copy link
Member

MridulS commented Apr 18, 2024

[testenv:unpinned]
description = Test with unpinned dependencies, as a user would install now.
deps =
-r requirements/basetest.txt
{{projectname}}

Here we are trying to fetch the latest release of the all the base requirements and the last release of package itself. Is the intent here to test the last release of the package with no pins, or the current main branch with no pins (or we should be doing both)?

The failures at https://github.com/scipp/ess-project?tab=readme-ov-file#ess are for packages which have no releases on pypi yet.

@YooSunYoung
Copy link
Member

I think it is intended.
The purpose of this test is to test the package in the environment of what users will have.
And we supposed that users will install it from package index frameworks, not from the main branch.

And I think we said we'll add unpinned test on main branch if it's needed,
so we can add a cron job testing the main branch with unpinned dependency that runs once a week maybe...?

@MridulS
Copy link
Member Author

MridulS commented Apr 22, 2024

And we supposed that users will install it from package index frameworks, not from the main branch.

Maybe we can just test {{projectname}} then? Ideally all the deps in requirements/basetest.txt should be already included in the {{projectname}} pip install?

@YooSunYoung
Copy link
Member

YooSunYoung commented Apr 22, 2024

No, basetest.txt dependency is only for the test-tools, so we want to pin the versions.
And we want to install unpinned version of the hard dependencies.

@SimonHeybrock
Copy link
Member

Yes, this is intended, see also https://github.com/scipp/ess-project?tab=readme-ov-file#overview-1:

Our Nightly test setup ensures that downstream projects keep working with changed merged upstream. There are two different Nightly runs, one to check if unreleased upstream changes break an existing downstream release, and a second one to check if unreleased upstream changes break the unreleased version (main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants