Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Script validate gradient table #1093

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VincentBeaud
Copy link
Contributor

Quick description

PR for this issue: #1074

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

Hello @VincentBeaud, Thank you for submitting the Pull Request !

Line 333:31: E128 continuation line under-indented for visual indent

Line 50:1: E305 expected 2 blank lines after class or function definition, found 1

@VincentBeaud
Copy link
Contributor Author

@karanphil Voici ce que j'ai à date. Un peu brouillon pour l'instant.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 15.21739% with 39 lines in your changes missing coverage. Please review.

Project coverage is 69.36%. Comparing base (5bcfd7f) to head (cb4933e).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   69.45%   69.36%   -0.10%     
==========================================
  Files         447      448       +1     
  Lines       24025    24097      +72     
  Branches     3280     3291      +11     
==========================================
+ Hits        16687    16714      +27     
- Misses       5943     5985      +42     
- Partials     1395     1398       +3     
Components Coverage Δ
Scripts 70.14% <58.75%> (-0.12%) ⬇️
Library 68.30% <30.43%> (-0.07%) ⬇️

@karanphil
Copy link
Contributor

@karanphil Voici ce que j'ai à date. Un peu brouillon pour l'instant.

Après avoir testé l'avenue de l'énergie, on va y aller avec juste ça! Ça marche bien et c'est déjà pas mal codé dans scilpy. Aussi, il y a des cas problématiques avec l'approche de l'angle. Donc cette PR pourra être fermée. Merci! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants