Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for list of lists of paths in assert_inputs_exist #1086

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Dec 12, 2024

Quick description

I added support for a list of lists of paths in scil_assert_inputs_exist.py. This arises when you mix nargs='+' with action='append'.

Closes #1067

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (ae1ce8f) to head (2aeb19b).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
+ Coverage   69.45%   69.46%   +0.01%     
==========================================
  Files         447      447              
  Lines       24052    24058       +6     
  Branches     3291     3295       +4     
==========================================
+ Hits        16706    16713       +7     
+ Misses       5947     5945       -2     
- Partials     1399     1400       +1     
Components Coverage Δ
Scripts 70.26% <ø> (+0.01%) ⬆️
Library 68.40% <25.00%> (+<0.01%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function assert_inputs_exist does not work with a list of lists
1 participant