lumi schema & name property

[andrewfowlie]

I was looking at the schema, trying to understand which elements are required etc. I noticed that the lumi modifier schema gives the name as well as the type to be { "const": "lumi" }

pyhf/src/pyhf/schemas/1.0.0/defs.json

Lines 115 to 122 in 3d26434

	"additionalProperties": false
	},
	"lumi": {
	"type": "object",
	"properties": {
	"name": { "const": "lumi" },
	"type": { "const": "lumi" },
	"data": { "type": "null" }

If I understand this correctly, it says that all lumi modifiers must be called lumi.

Compare this to other modifiers e.g., shapesys.

pyhf/src/pyhf/schemas/1.0.0/defs.json

Lines 165 to 170 in 3d26434

	"shapesys": {
	"type": "object",
	"properties": {
	"name": { "type": "string" },
	"type": { "const": "shapesys" },
	"data": { "type": "array", "items": {"type": "number"}, "minItems": 1 }

here, it seems like the name can be any string you want.

Do I understand this correctly? Is this lumi restriction deliberate so that there can only ever be a single lumi modifier named lumi? This kind of makes sense, although I could imagine wanting to have different lumi modifiers, especially if I was including both ATLAS and CMS data. Or is it a copy-paste error since it is the same as the line below it?