From e6e27d625abd534d6f189a190e2a74a38b1f4084 Mon Sep 17 00:00:00 2001
From: Henry Schreiner <henry.fredrick.schreiner@cern.ch>
Date: Wed, 16 Oct 2019 10:57:42 +0100
Subject: [PATCH] Adding Python 3.8 (#145)

* Adding Python 3.8

* Fix build with 3.8

* Dropping 3.8 from manylinux1
---
 .ci/azure-build-pipeline.yml |  2 ++
 .ci/build-wheels.sh          | 11 +++++++++++
 .ci/macos-install-python.sh  |  3 +++
 CHANGELOG.md                 |  3 +++
 README.md                    |  2 +-
 5 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/.ci/azure-build-pipeline.yml b/.ci/azure-build-pipeline.yml
index ca1ffd56..97d87229 100644
--- a/.ci/azure-build-pipeline.yml
+++ b/.ci/azure-build-pipeline.yml
@@ -66,6 +66,8 @@ jobs:
         python.version: '3.6'
       Python37:
         python.version: '3.7'
+      Python38:
+        python.version: '3.8'
   pool:
     vmImage: 'macOS-10.14'
   steps:
diff --git a/.ci/build-wheels.sh b/.ci/build-wheels.sh
index 900c96eb..056c7507 100755
--- a/.ci/build-wheels.sh
+++ b/.ci/build-wheels.sh
@@ -4,9 +4,20 @@ set -e -x
 # Collect the pythons
 pys=(/opt/python/*/bin)
 
+# Print list of Python's available
+echo "All Pythons: ${pys[@]}"
+
 # Filter out Python 3.4
 pys=(${pys[@]//*34*/})
 
+# Filter out Python 3.8 on manylinux1
+if [[ $PLAT =~ "manylinux1" ]]; then
+    pys=(${pys[@]//*38*/})
+fi
+
+# Print list of Python's being used
+echo "Using Pythons: ${pys[@]}"
+
 # Compile wheels
 for PYBIN in "${pys[@]}"; do
     "${PYBIN}/pip" install -r /io/dev-requirements.txt
diff --git a/.ci/macos-install-python.sh b/.ci/macos-install-python.sh
index 6f6e95a5..f1cbe11f 100755
--- a/.ci/macos-install-python.sh
+++ b/.ci/macos-install-python.sh
@@ -12,6 +12,9 @@ case $PYTHON_VERSION in
 3.7)
   FULL_VERSION=3.7.3
   ;;
+3.8)
+  FULL_VERSION=3.8.0
+  ;;
 esac
 
 INSTALLER_NAME=python-$FULL_VERSION-macosx10.9.pkg
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 21c25003..0da16ef2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,3 +6,6 @@ First beta release and beginning of the changelog.
 
 * Unlimited storage does not support pickling or classic multiprocessing
 * Some non-simple storages do not support some forms of access, like `.view`
+* Indexing and the array versions (such as centers) are incomplete and subject to change
+* The numpy module is provisional and subject to change
+* Docstrings and signatures will improve in later versions (especially on Python 3)
diff --git a/README.md b/README.md
index 809561f5..6c0a0ddf 100644
--- a/README.md
+++ b/README.md
@@ -15,7 +15,7 @@ Python bindings for [Boost::Histogram][] ([source][Boost::Histogram source]), a
 
 ## Installation
 
-This library is under development, but you can install directly from GitHub if you would like. You need a C++14 compiler and Python 2.7--3.7. Boost 1.71 is not required or needed (this only depends on included header-only dependencies).
+This library is under development, but you can install directly from GitHub if you would like. You need a C++14 compiler and Python 2.7--3.8. Boost 1.71 is not required or needed (this only depends on included header-only dependencies).
 All the normal best-practices for Python apply; you should be in a virtual environment, otherwise add `--user`, etc.
 
 ```bash