Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: version check in to_cudf for API change #3339

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: version check in to_cudf for API change #3339

wants to merge 3 commits into from

Conversation

martindurant
Copy link
Contributor

fixes #3335

@martindurant
Copy link
Contributor Author

martindurant commented Dec 11, 2024 •
edited
Loading

@jpivarski , give me a little time on this to check on my GPU machine for different environments.

Should we add a general caveat to the user-facing ak.to_cudf docstring, that the cudf backend API is anticipated to perhaps be unstable?

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (b749e49) to head (c43f364).
Report is 215 commits behind head on main.

Files with missing lines Patch % Lines
src/awkward/contents/listoffsetarray.py 0.00% 7 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/contents/listoffsetarray.py 80.77% <0.00%> (-2.10%) ⬇️

... and 161 files with indirect coverage changes

@martindurant
Copy link
Contributor Author

Tested for cudf 24.10.01 and 24.08.03 🆗

@martindurant
Copy link
Contributor Author

Failures have something to do with JAX?

@pfackeldey
Copy link
Collaborator

Failures have something to do with JAX?

should be fixed by #3340 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CuDF backend doesn't check CuDF version before doing version-dependent things
2 participants
@martindurant @pfackeldey