Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora packaging #47

Open
LecrisUT opened this issue Aug 7, 2024 · 9 comments · May be fixed by #56
Open

Fedora packaging #47

LecrisUT opened this issue Aug 7, 2024 · 9 comments · May be fixed by #56

Comments

@LecrisUT
Copy link
Collaborator

LecrisUT commented Aug 7, 2024

Let me know when I should start packaging this project.

@henryiii
Copy link
Contributor

henryiii commented Aug 7, 2024

Probably after #32 is in and we make a release?

@henryiii
Copy link
Contributor

v0.2.0 is out.

@LecrisUT
Copy link
Collaborator Author

Are the UseCython.cmake files effectively vendored or would they be forked? If the latter could you change the copyright notice for it to reflect that?

@henryiii
Copy link
Contributor

If someone uses this package, they would use the files from the package. If they prefer, they can vendor the files, which means they don't need to get this package from Fedora. What change were you thinking of?

@LecrisUT
Copy link
Collaborator Author

I was thinking about the more general case:

# Copyright 2011 Kitware, Inc.

If the file is being maintained externally than I would need to add a Bundles to show that, otherwise it would be fine as-is

@henryiii
Copy link
Contributor

I think that date was inherited. @jcfr?

@LecrisUT
Copy link
Collaborator Author

Was thinking you could just add

# Copyright 202x Scikit-build developers

Or equivalent, marking when it got forked from kitware's

@henryiii
Copy link
Contributor

I don't think it's a good idea to assign copyright to something that's not a legal entity. A person works, or a company, but "... developers" is too fuzzy and unclear. That's what I remember from a discussion with a lawyer a long time ago, I might be misremembering it though.

@LecrisUT
Copy link
Collaborator Author

I remember there being some discussion on Fedora mail list1 about jaraco removing copyright notice2. I need to read through the mail list more carefully, but afaiu it is ok if the authorship is self contained. There is also this article which many people resonate with, but of course inal.

Footnotes

  1. https://lists.fedoraproject.org/archives/list/[email protected]/thread/FOS55EPT4MEJXIY3CHWM26X5ACG66TQU/

  2. https://github.com/jaraco/skeleton/issues/78

@LecrisUT LecrisUT linked a pull request Sep 25, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants