Remove child work search filter

[grahamjevon]

Noticed during testing for #451

Problem

When creating relationships between works, four filters are applied to the lookup search filter. Three of these filters make sense and should be kept. These are: :show_only_other_works, :show_only_works_not_child, :show_only_works_not_parent

The following filter, however, is problematic :show_only_resource_depositord_by_current_user. This filter means that if I upload a work, Nora would not be able to add it as the child of another work using? So if I uploaded a work today and leave the organisation tomorrow, thereafter no-one will be able to add that work as the child of another work?

This problematic filter might be appropriate if we had a self-deposit system (e.g. every member of staff had login credentials and uploaded their own outputs as works). However, it is problematic when we only have a limited number of administrators doing all the uploading.

Solution

Keep the first three filters and remove the fourth filter: :show_only_resource_depositord_by_current_user.

[grahamjevon]

Staging works as expected. I can create relationships between works regardless of whether I deposited the work. For example, I could add a work added by Jenny to another work added by Jenny.