Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport via label did not trigger #50

Closed
pllim opened this issue Jul 26, 2021 · 5 comments
Closed

Backport via label did not trigger #50

pllim opened this issue Jul 26, 2021 · 5 comments

Comments

@pllim
Copy link
Contributor

pllim commented Jul 26, 2021

https://meeseeksbox.github.io/ mentioned that it is possible to trigger backport via label as long as description has the directive. Over at https://github.com/astropy/astropy/labels , we have a backport-v4.3.x label with the description as required. But when applied to, say astropy/astropy#11971, it did not trigger backport bot to open a backport PR on merge. What did we do wrong? Hope you can advise. Thanks!

@Carreau
Copy link
Contributor

Carreau commented Jul 28, 2021

Hum, I think the issue is arround here:

https://github.com/MeeseeksBox/MeeseeksDev/blob/6b733c284c9107968775919728ebae4fdca0fa06/meeseeksdev/meeseeksbox/core.py#L376-L383

  1. it looks only at the milestone
  2. it should check for the repo base branch and not hardcoded "master".

I can't promise I'll fix this soon, but I can give you access to this repo and heroku if you want to try to fix it yourself.

Carreau added a commit that referenced this issue Jul 28, 2021
For now hardcode both master and main.
@Carreau
Copy link
Contributor

Carreau commented Jul 28, 2021

Oh, actually the labels are taken care of a bit higher, so it might just be "master"/"main" I've tried to push a workaround.

@pllim
Copy link
Contributor Author

pllim commented Jul 28, 2021

Thanks! I'll keep an eye on it and report back. We don't backport every day.

@Carreau
Copy link
Contributor

Carreau commented Jul 28, 2021

Seeing MeeseeksBox/test1#84 that should work now.

@pllim
Copy link
Contributor Author

pllim commented Jul 28, 2021

Yay, it indeed works now. Thank you so much for the quick fix!

@pllim pllim closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants