Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing calls to ais8_1_26_append_pydict_sensor_hdr in ais_py.cpp #214

Open
andyvan-trabus opened this issue Sep 7, 2021 · 0 comments

Comments

@andyvan-trabus
Copy link
Contributor

I noticed while implementing parsing for ais8_367_33, which is remarkably similar, that the switch statement in ais8_1_26_append_pydict only calls ais8_1_26_append_pydict_sensor_hdr for a couple of the cases (SENSOR_LOCATION, SENSOR_STATION), but not for any of the others. Since I don't have the message standard, I don't know whether this is an oversight or not.

From the similarity with ais8_367_33 I suspect that all of these cases should call that routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant