Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-undo tests don't work with PyMOL 2.5 #9

Open
speleo3 opened this issue Aug 31, 2023 · 0 comments
Open

--no-undo tests don't work with PyMOL 2.5 #9

speleo3 opened this issue Aug 31, 2023 · 0 comments

Comments

@speleo3
Copy link
Contributor

speleo3 commented Aug 31, 2023

The runall.pml script currently runs tests with --offline --no-mmlibs --no-undo. Removing these flags makes 9 tests fail with PyMOL 2.5.6.

6 of these failures come from --no-undo and these tests seem unsupported by any modern PyMOL version.

FAIL: test (tests/jira/PYMOL-1276_py.Test1276)
FAIL: testUndoAfterRemoveAtomOnDiscrete__0 (tests/jira/PYMOL-1697_py.TestPYMOL1697)
FAIL: testUndoAfterRemoveAtomOnDiscrete__1 (tests/jira/PYMOL-1697_py.TestPYMOL1697)
FAIL: testAtomLevelSettingsOnRemove (tests/jira/PYMOL-1567_py.TestPYMOL1567)
FAIL: testAtomLevelSettingsOnRemove2 (tests/jira/PYMOL-1567_py.TestPYMOL1567)
FAIL: testAtomStateLevelSettingsOnRemove (tests/jira/PYMOL-1567_py.TestPYMOL1567)

I suggest to either fix those tests for the new undo system, or remove them.
speleo3 added a commit to speleo3/pymol-testing that referenced this issue Sep 1, 2023
@speleo3
Make --no-mmlibs --no-undo the default
71d9bac 
These tests seem unsupported by modern PyMOL versions (like 2.5.6), see
schrodinger#9

Add `--with-mmlibs` and `--with-undo` options to enable these tests.
@speleo3 speleo3 mentioned this issue Sep 1, 2023
Closed
speleo3 added a commit to speleo3/pymol-open-source that referenced this issue Jan 31, 2024
@speleo3
Make --no-mmlibs --no-undo the default
bd4e3ab 
These tests seem unsupported by modern PyMOL versions (like 2.5.6), see
schrodinger/pymol-testing#9

Add `--with-mmlibs` and `--with-undo` options to enable these tests.
@speleo3 speleo3 mentioned this issue Jan 31, 2024
Merged
JarrettSJohnson pushed a commit to schrodinger/pymol-open-source that referenced this issue Jan 31, 2024
@speleo3
Support running all tests with pytest, make --no-mmlibs --no-undo the…
9dcb209 
… default (#333)

* Support running all tests with pytest

* Make --no-mmlibs --no-undo the default

These tests seem unsupported by modern PyMOL versions (like 2.5.6), see
schrodinger/pymol-testing#9

Add `--with-mmlibs` and `--with-undo` options to enable these tests.

* Require PyMOL 2.6 for testLoadPLY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@speleo3