Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable rows? #620

Open
zthomas1 opened this issue Jan 26, 2022 · 5 comments
Open

Resizable rows? #620

zthomas1 opened this issue Jan 26, 2022 · 5 comments

Comments

@zthomas1
Copy link

Similar to the resizable column functionality are there any plans to support resizable rows via the same type of drag handle?

@zthomas1
Copy link
Author

zthomas1 commented Jan 26, 2022

if not, would you be supportive of a PR to implement this and perhaps also some expansion to the current column resize functionality that someone else already created an issue about and was labeled as a potential "enhancement".

for reference:
#180

@zthomas1
Copy link
Author

Bueller? My team is ready to move on this but, would like some confirmation that this library is still active and viable before making the investment versus swapping to react-base-table perhaps.

@pradeepnschrodinger
Copy link
Collaborator

Hey @zthomas1 , sorry for the delay.
We currently don't have row resizing implemented out of the box but we'll be happy to take in a PR.

Since the original issue (#180) is a few years old, I'll just put a short recap here of the present code state:

Right now in master, column resizing is baked into the FDT's cell component FixedDataTableCell.js.
The table component accepts props like onColumnResizeEndCallback to enable and make use of column resizing.
One way to implement row resizing might be to simply expose another set of props following the approach of onColumnResizeEndCallback.

With that said, our future plan is to completely separate out resizing functionality into a separate reusable react component which the users can simply add into their cells.
In fact, the latter is already implemented in our v2.0-beta branch, through the ResizeCell component (a code example can be seen here).

Let me also know if you need any pointers on anything.

@zthomas1
Copy link
Author

zthomas1 commented Jan 31, 2022

Thank you for the response and the input, I completely agree with your approach regarding the separate component.

In fact, with some tweaking of the ResizeCell component callbacks or the creation of a single onResize callback, and of course handling up the stack, it could hopefully be made to support both column and row resizing.

Do you have an idea when the v2 might be released.

For a production environment where stability matters, of course, I am trying to determine if it would be best to build from your v2 beta or master.

Appreciate your thoughts.

@pradeepnschrodinger
Copy link
Collaborator

Do you have an idea when the v2 might be released.

Beta versions of v2 are already released. Feel free to build against the latest one -- v2.0.0-beta.5.
Do note that v2.0-beta releases are not yet heavily tested...
We do have a testing request for v2-beta planned for the next month or so, after which we expect to release a non-beta v2, but for now there's no definite release date.

For a production environment where stability matters, of course, I am trying to determine if it would be best to build from your v2 beta or master.

Since this is for a production environment, currently it's better off to build against master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants