Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Unit Test for #460 #466

Open
pradeepnschrodinger opened this issue Jun 17, 2019 · 0 comments
Open

Write Unit Test for #460 #466

pradeepnschrodinger opened this issue Jun 17, 2019 · 0 comments
Labels

Comments

@pradeepnschrodinger
Copy link
Collaborator

Context

Cells can have stale props.

Our buffered rows renders stub/fake rows to avoid mounts/unmounts. These rows have temporary props that don't reflect the table's props since the rows won't anyway be visible to the user. But the props propagate to the cell.
The cells have a shouldComponentDidUpdate to skip renders, so even when the rows become "real" the cells aren't re-rendered with the updated props.

Added an example to easily catch these cases in the future.

Write a unit test to catch cells having stale props (derived from #460 - Beta fix stub cells)

Target Version: v1.0-beta (latest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants