You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Osprey actively excludes basis set elements which don't conform to its naming conventions, even when explicitly asked to include everything (Included Metabolites => Full) in the basis set. This leads to omission of key metabolites from basis sets with alternative/legacy naming conventions -- most prominently, Ins vs mI (both of which are acceptable in the LCModel world, ref table 8.1 of the LCM manual).
To Reproduce
From the Osprey job creation GUI...
Fitting algorithm => LCModel
Included Metabolites => Full
Basis set file => A basis set which dares to label "mI" as "Ins" or "mIns" (eg, this one: problematic.basis.txt)
Load and fit the data
Observe horrifying residuals where mI should be.
Expected behavior
All the metabolites in the basis set are included when "included metabolites" is set to "full".
Additional context
I'm fairly sure the exclusion is happening around Line 378 of osp_fitInitialise.m. Not really sure what an appropriate solution would be; some possible options:
If "included metabolites" is set to full, don't create "chomit" entries for any item which exists in the basis set. This is a good general solution for arbitrary metabolites, but won't actually solve the problem for mI/Ins with the "default" set of included metabolites
Update the list of metabolites (checkboxes) according to the contents of the selected basis set. This is awkward to implement, but nicely generalisable
Implement aliases/renaming for the most common variants. An incomplete, messy solution but addresses the most critical issues.
Just detect and warn users in this scenario so they can update the basis set accordingly
The text was updated successfully, but these errors were encountered:
Describe the bug
Osprey actively excludes basis set elements which don't conform to its naming conventions, even when explicitly asked to include everything (Included Metabolites => Full) in the basis set. This leads to omission of key metabolites from basis sets with alternative/legacy naming conventions -- most prominently, Ins vs mI (both of which are acceptable in the LCModel world, ref table 8.1 of the LCM manual).
To Reproduce
From the Osprey job creation GUI...
Expected behavior
All the metabolites in the basis set are included when "included metabolites" is set to "full".
Additional context
I'm fairly sure the exclusion is happening around Line 378 of osp_fitInitialise.m. Not really sure what an appropriate solution would be; some possible options:
The text was updated successfully, but these errors were encountered: