Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to disable automatic C mounting #557

Open
sabudum opened this issue Dec 2, 2024 · 5 comments
Open

No way to disable automatic C mounting #557

sabudum opened this issue Dec 2, 2024 · 5 comments

Comments

@sabudum
Copy link

sabudum commented Dec 2, 2024

When loading any type of content with dosbox-pure, be it a zip, or a conf, or anything else, it automaticaly mounts the same folder as the content as the C drive.
This breaks behavior of autoexec commands in conf files.

I need to use conf files directly the same way I would with other dosbox forks, but with this kind of behavior, it's impossible.

@BenoitBounar
Copy link

Yes this would be useful for mounting subfolders in zip files

@digitalLumberjack
Copy link

Would be really cool for Recalbox too !

@alexb3d
Copy link

alexb3d commented Dec 4, 2024

it automaticaly mounts the same folder as the content as the C drive.

This is not random, DB-Pure mounts the folders respecting the original structure of a PC.

It is not a fork like the others. Note that it is deeply tied to the RetroArch interface and all its advanced features.

Almost everything is configured automatically, the .conf is not necessary and some of its commands are not compatible, indeed they generate errors.

Pre-compiled files must be unzipped, the first folder discarded and then re-zipped.

@schellingb
Copy link
Owner

When loading something like a ZIP file with a .conf file inside it, the ZIP file has to be mounted as C:. The [autoexec] section of the .conf can then remount it to something else if it wants. Because loading ZIP files is not something regular DOSBox does, this should not be seen as a difference to regular DOSBox.

Though when loading a .conf file as content directly from the libretro frontend, there is an argument to be made that the directory which the .conf is inside should not be mounted as C:, and any mounting would have to be done by the [autoexec] section (or manually in the command line). I wonder if it would break setups already in use if that were to change now...

schellingb added a commit that referenced this issue Dec 14, 2024
)

This matches other DOSBox libretro cores as well as regular DOSBox when specifying a conf file via launch arguments
@schellingb
Copy link
Owner

This change has now been made with 710120a. In addition c2730d6 and 59a20b1 were made which enables mounting paths relative to the loaded content in the command line. Meaning if you have "GAME.ISO" in the same folder as the .conf you are loading, the conf file can have imgmount D GAME.ISO -t iso in its [autoexec] section and it will find the correct file. This also matches the other DOSBox libretro cores.

Again, this change only affects when loading a .conf as content directly. Other means of loading .conf (for example inside a ZIP or next to the loaded ZIP) will still work as always. It doesn't make sense to only load dosbox.conf out of the ZIP file and then not have the other content of the ZIP available as a mounted drive, right?

This very likely will be a breaking change for people who have relied on the current behavior. But I feel like matching the other DOSBox cores in this regard is more correct. To adapt to the new behavior one will need to add a line with mount C: . at the top of the [autoexec] section of the loaded .conf file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants