-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sun to moon if night time #115
Conversation
according to #106
replace sunny to moon if night time
@schachmat Maybe I send many commits to this PR. |
Heyho @R11baka, Thanks again for your great work! There was already an attempt at this issue in PR #88, but there were still 3 points missing. You managed to tackle the first two already. I'd be happy to merge your PR if you handle the last one as well, adding night-alternative icons for every condition code where a sun is visible currently. It would be a little inconsistent if you have a moon displayed in the |
Oh and an implementation hint. Just copy the |
@schachmat If I understand correctly, I should replace codeSunny, partly rainly,partly cloudly,partly light rain ? |
There is a sun visible in:
They might seem like a lot, but since the sun is clipped equally in most of them, replacing the sun with a moon should not be too hard. |
Hi @schachmat . Created new pull request |
Resolve #68