Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew formula for kalibrate-hackrf #10

Open
rxseger opened this issue Jun 6, 2016 · 6 comments
Open

Homebrew formula for kalibrate-hackrf #10

rxseger opened this issue Jun 6, 2016 · 6 comments

Comments

@rxseger
Copy link
Collaborator

rxseger commented Jun 6, 2016

Instead of https://github.com/scateu/kalibrate-hackrf/blob/master/INSTALL.homebrew manual instruction steps, why not submit a formula to homebrew-core so installation is simple as brew install kalibrate-hackrf?

I started one here: https://github.com/rxseger/homebrew-hackrf/blob/master/kalibrate-hackrf.rb - it is not in the main homebrew-core repo, so it has to be tapped:

brew tap rxseger/homebrew-hackrf
brew install kalibrate-hackrf

also it uses https://github.com/rxseger/kalibrate-hackrf instead of https://github.com/scateu/kalibrate-hackrf primarily for #8, but this could be changed.

And it doesn't fully follow the homebrew formula cookbook rules yet. The main blocker seems to kalibrate-hackrf would need a "stable release", e.g. a version tag, instead of only the git development 'master' branch:

Stable versions
Formulae in the core repository must have a stable version tagged by the upstream project. Tarballs are preferred to git checkouts, and tarballs should include the version in the filename whenever possible.

Software that only provides a development/beta, tagged version should be put in homebrew/devel-only. We don’t accept software without a tagged version because they regularly break due to upstream changes; we can’t provide bottles for them; and we don’t have an automatic update mechanism for head-only formulae which makes them very quickly outdated.

would you be willing to make an official "release" of kalibrate-hackrf for this purpose?

@scateu
Copy link
Owner

scateu commented Jun 6, 2016

Hi Robert,

It's a great pleasure to see that this project works for you. But I am
currently some kind of busy, and there is not enough time for me to
submit a pull request for homebrew-core repo or do other kind of
maintainance work.

I have added you as a collaborator of this project. You can push your
changes directly into this repo, and do what you need to make this project
more useful for other people.

Thanks.

Wang Kang

@rxseger
Copy link
Collaborator Author

rxseger commented Jun 6, 2016

Thanks scateu! I'll see what I can do.

@rxseger
Copy link
Collaborator Author

rxseger commented Jun 6, 2016

@scateu trying to push changes from my fork to here but I'm getting access denied, can you check:

kalibrate-hackrf $ git remote -v | grep origin
origin  [email protected]:scateu/kalibrate-hackrf (push)
origin  [email protected]:scateu/kalibrate-hackrf (fetch)
kalibrate-hackrf $ git push -u origin master
ERROR: Permission to scateu/kalibrate-hackrf.git denied to rxseger.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@scateu
Copy link
Owner

scateu commented Jun 6, 2016

Collaborators
Push access to the repository

 @rxseger
 Robert X. Seger
 Awaiting rxseger's response

It seems that you have to confirm my invitation at some where.

@rxseger
Copy link
Collaborator Author

rxseger commented Jun 7, 2016

Got it, cheers! Pushed my changes

@rxseger
Copy link
Collaborator Author

rxseger commented Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants