Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chicago Health Atlas coverage files to have .json extension instead of .csv #66

Open
vingkan opened this issue Jul 17, 2021 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation pipeline Work for offline pipeline refactor Work to refactor part of the codebase.

Comments

@vingkan
Copy link
Contributor

vingkan commented Jul 17, 2021

I made a mistake when I wrote the extract steps for the population dataset by naming the population coverage file .csv even though the contents of the file are actually JSON. We even read the coverages file as JSON in the transform steps, we just never fixed the file extensions.

Unfortunately that mistake has been copied into most of our other dataset extraction steps.

This issue is non-urgent, but we should rename those and update the documentation.

Don't forget to update all the places a coverage file for a specific dataset is mentioned:

  • Extract step target name
  • Extract step output file
  • Transform step input file
  • Transform step target dependency
  • Documentation
@vingkan vingkan added documentation Improvements or additions to documentation pipeline Work for offline pipeline refactor Work to refactor part of the codebase. labels Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pipeline Work for offline pipeline refactor Work to refactor part of the codebase.
Projects
None yet
Development

No branches or pull requests

2 participants