-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/SK-1078 | Added virtual environment details in quickstart #715
Conversation
…nging from / to \ in the PowerShell command lines to better match standard conventions for path in PowerShell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment, request review again after answer.
docs/quickstart.rst
Outdated
:caption: Windows (Powershell) | ||
|
||
python -m venv fedn_env | ||
.\fedn_env\Scripts\Activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested this? I was not able to do this is my powershell because of admin rights, instead I used CMD.exe and then there is a .bat file to activate instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do further testing later today on my windows machine.
Wouldn't switching to CMD be a bad decision since we later use PowerShell to start the clients?
A workaround could also be starting PowerShell in admin mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it and it works on my windows machine, I've added a line to bypass the admin permissions if that error shows up
I also added copy code buttons for the code boxes to make it easier to work with the guides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want atleast 2 windows machine to have tested it. I can test on mine, but probably next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested changes orally
Added instructions for CMD.exe and also added a link to Python venv documentation if further information is needed. |
Added a step (1.5) in the quickstart guide of how to set up and activate a virtual environment.