enhancement to run scalatest test with ScalaRunner #51
Conversation
|
hi @wpopielarski thanks for the great enhancement! We highly appreciate your help, like many other open source projects ScalaTest's project policy requires contributor to sign a CLA first before we can merge in the code, can you please print, sign, scan the following CLA: http://www.artima.com/cla/contributorsLicenseAgreement.pdf or for corporation: http://www.artima.com/cla/corpContributorsLicenseAgreement.pdf and please send the signed copy to: We apologize for the tedium, we have been wanting to provide a digital way to do it, but unfortunately have not found an opportunity to do it yet. |
|
The fix message is inaccurate - ScalaTest has its own ticket tracker. |
| runner.run(runConfig, launch, monitor) | ||
|
|
||
| // check for cancellation | ||
| if (monitor.isCanceled()) |
There was a problem hiding this comment.
We are already at the end of the method - no need to do this check.
| configMap.put(SCALATEST_LAUNCH_TESTS_NAME, testNameSet) | ||
|
|
||
| config.setAttributes(configMap) | ||
|
|
There was a problem hiding this comment.
setAttributes(map) overrides all attributes (even if they had been read from .launch file. A code below just sets/overrides some of them.
|
Hi wpopielarski, Wanted to ping you on the CLA. Are you OK with it? Thanks. Bill |
|
Hi Bill Regards 2015-06-02 7:31 GMT+02:00 Bill Venners [email protected]:
|
|
generally i sent cla 6 days ago 2015-06-02 8:28 GMT+02:00 Wieslaw Popielarski [email protected]:
|
|
here is an email Hello CLA team, let me send you signed docs to get a consent to contribute into Regards, ---------- Forwarded message ---------- hi @wpopielarski https://github.com/wpopielarski thanks for the great http://www.artima.com/cla/contributorsLicenseAgreement.pdf or for corporation: http://www.artima.com/cla/corpContributorsLicenseAgreement.pdf and please send the signed copy to: We apologize for the tedium, we have been wanting to provide a digital way — |
|
Hi Wieslaw, Ah, great. I checked my inbox and don't see it yet. I'll double check the alias and see if I can find it. Thanks. Bill |
|
Hi Wieslaw, Found it in my spam folder. Apparently it thought your email might be a phishing attack. Thanks again for the contribution and we'll try and get it in quickly now that we found the CLA. Bill |
|
Hi Wieslaw, By the way Chee Seng checked and your email was also in his spam folder. Perhaps something unusual in the headers perhaps? Gmail thought for some reason the email might not be from who it said it was from. Bill |
|
no worries guys :), i'm glad I can contribute :) 2015-06-02 20:24 GMT+02:00 Bill Venners [email protected]:
|
|
@wpopielarski i am trying to build after merging your changes, but I got this: I wonder if I am building against wrong scala-ide version, I have tried building againts: and May I know which scala-ide url did you build with? Thanks. |
|
let me check if it is available in nightly build. The PR with the change 2015-06-03 6:11 GMT+02:00 Chua Chee Seng [email protected]:
|
|
sorry for late response. To run it with latest scala-ide you need to change url in pom.xml from hope it helps ps. just to be sure |
|
Sorry was busy with ScalaTest 3.0.0-M1 recently. I just try again and it seems to be building fine with master, just one more question, is ScalaRunner support included in the 4.1 release? Or it is targetted for the next release? Thanks. |
|
All the new types are not yet available in 4.1, they are targeted for the next release. |
|
@wpopielarski sschaef I have merged the changes into a branch called 'nightly', and updated the main README about building for nightly to use that new branch instead. Anyway, I think our branches at its current state are really bad, we shall do a restructure soon. |
|
thanks a lot, I hope it will be cool feature 2015-06-12 10:07 GMT+02:00 Chua Chee Seng [email protected]:
|
| @@ -25,6 +25,7 @@ Require-Bundle: | |||
| org.scala-lang.scala-compiler;bundle-version="[2.11.0,2.12.0)", | |||
| org.scala-lang.scala-reflect, | |||
| org.scala-ide.sdt.core;bundle-version="[4.0.0,5.0.0)", | |||
| org.scala-ide.sdt.debug;bundle-version="[4.0.0,5.0.0)", | |||
There was a problem hiding this comment.
This is incorrect. You can't depend on 4.0.0, you need to depend on [4.2.0, 5.0.0)
|
Could we get this in soon? It'd be cool to have eval expression support in tests. |
currently the scalatest launcher uses standard java vm runner to run or debug tests. It works fine with a java expression evaluator but with the Scala IDE 4.1.0 there is available the Scala Expression Evaluator which requires a Scala Debugger. This enhancement adds a new scala launcher. From now it is possible to choose appropriate launcher: - an old java one especially for java projects where tests are written with scalatest. Then debugging and evaluation can be done with a java evaluator - a new scala one for scala projects (can be used for java projects as well but is not documented). You can stop in breakpoint during a test execution and evaluate arbitrary expression. This PR must be taken with scala-ide PR #955 Fix #1002447
|
Updated and pushed 2015-07-17 12:36 GMT+02:00 Iulian Dragos [email protected]:
|
|
@dragos @wpopielarski sorry too tied up for the upcoming scalactic/scalatest 3.0.0, i have merged this into 'nightly' branch instead of the branch this PR is submitted for: https://github.com/scalatest/scalatest-eclipse-plugin/commits/nightly reason is kepler-nightly-2.11 branch is used to build for scala-ide 4.1 and this changes does not seem to be compatible with 4.1, did i missed anything to be pulled into the 'nightly' branch? Thanks! |
|
@wpopielarski @sschaef Indeed we have a separate branch to build for 4.2 due to the enhancement done in this PR, which I believe is only available in 4.2 and not 4.1.1, I have rebuilt the latest combined site for 4.1.1 (using old branch for 4.1) and uploaded it to: http://www.artima.com/newplugins3/combined Scala IDE update site should pick it up within 24 hours normally, is there a url available to build for 4.2? |
|
4.2 is not yet available, but I'm going to notify you once it is. Beside from that I would like to know why you decided in the first place to build binaries by yourself. Wouldn't it be easier if the Scala IDE team grabs the sources and publishes a version by itself? |
|
@sschaef @wpopielarski The story was actually @skyluc from Scala IDE team helped us to set it up that way, I don't 100% understand how it works from the Scala IDE side, it is not really our choice indeed. :) |
|
Ok, I'm going to investigate what it takes from our side to also build the scalatest-plugin from source as we do it for all other scala-ide plugins. |
|
@sschaef that would be great, fyi currently here's how I am building the 'combined' update site: (with java on the path is java 6) the output will be saved to ~/tmp/scalatest-build-ecosystem |
|
Can you build against http://download.scala-ide.org/nightly-scala-ide-luna-211x? It contains the nightlies for 4.2, I don't think we need to publish an extra version of 4.2-RC1 somewhere, since the release is binary compatible. |
|
I looked at your |
|
4.2.0-RC1 is staged at: http://download.scala-ide.org/sdk/next/lithium/e44/scala211/dev/base/ |
|
@sschaef @skyluc @dragos Sorry for the late response, got a father duty to attend to. I just tried the 4.2.0-RC1 and installed the ScalaTest plugin and it seems to be working (I tested the test selection to run test, and hopping back to source feature), but I am not sure how to test the ScalaRunner support added in this PR, do you mind to explain the feature a little bit? As for the ecosystem-build.sh, as far as I can tell, it is building the plugins for different versions of Scala IDE (by checking out different branches of the ScalaTest plugin), and create a combined update site that contains all of them. Scala IDE update sites then will pull the correct version of ScalaTest plugin into their corresponding update site instead (e.g. Scala IDE 3.x will pull ScalaTest plugin built for Scala IDE 3.x, Scala IDE 4.x will pull ScalaTest plugin built for Scala IDE 4.x). Shall I still need to build a dev combined site containing the version that built with the above url so that you can pull it? Thanks. |
|
sorry for cutting in but in fact you can test it together with Expression Regards 2015-08-19 17:57 GMT+02:00 Chua Chee Seng [email protected]:
|
|
@sschaef @wpopielarski I am trying to use Expression Evaluator with Debug using scala runner (via 4.2-rc1), but got the following runtime error when trying to run with scala runner: and the same error encountered when running a normal Scala application (with main method), do you have idea what could have gone wrong? I am using eclipse Luna. Thanks. |
|
Is there a stack trace available for it? |
|
@sschaef not sure how I can get the stack trace, the following is shown in the 'Problem Occurred' dialog after I clicked on the 'Details' button, from command console it seems to say this: |
|
The Error Log View contains all errors and should also log the exception. |
|
@sschaef thanks, here's the stack trace from the error log view: |
|
looks more like a problem with build not expression evaluator 2015-08-26 4:02 GMT+02:00 Chua Chee Seng [email protected]:
|
|
@sschaef @wpopielarski One thing is that I only installed the items under Scala IDE for Eclipse, and not Scala IDE for Eclipse Development Support, Scala IDE for Eclipse Source Feature and Scala IDE plugins, I wonder if that matters? |
|
Let me verify it today. Thanks for your efforts 2015-08-26 5:48 GMT+02:00 Chua Chee Seng [email protected]:
|
|
This usually means a missing entry in |
|
Hi Chua, 2015-08-26 10:46 GMT+02:00 Iulian Dragos [email protected]:
|
|
@dragos @wpopielarski Installing Scala IDE Dev support fixed the problem, but seems to be this dependency should be in sdt.core, as the same problem occurs when used with debugging Scala Application (new debugger). fyi, the eclipse that i am using is eclipse-java-luna-SR2. |
|
@dragos @wpopielarski @sschaef by the way, I built a combined update site that contains the build for 4.2, I uploaded the combined site here: http://www.artima.com/newplugins3/combined-next Hopefully you can pull from it to include in the 4.2-rc1 update site. Thanks. |
|
I did a dryrun for 4.2-rc2 and it successfully picked up the new version.Thanks for you work! |
|
The problem why the problem about the missing VMHelper class occurs is not because Scala IDE doesn't depend on it, the problem is that this class is not available in a non PDE environment (which is the case for the eclipse-java-luna-SR2 installation). Users explicitly have to install PDE to get this version. I don't know if it is possible to add PDE as a requirement to the OSGi configuration. I wonder why you could fix the problem by installing the dev support because it doesn't come with additional dependencies. Maybe you installed PDE too? Anyway, even with PDE, the expression evaluator can't be used. I get this error message: |
|
It's been 3 years and Scala IDE is 4.7.1 now, and yet expression evaluation still doesn't work with ScalaTest. What is the status of this PR? It the project itself still alive? |
|
there no fund to sponsor this feature right now. sorry for these bitter
words.
2018-06-06 15:44 GMT+02:00 Alex Abdugafarov <[email protected]>:
… It's been 2 years and Scala IDE is 4.7.1 now, and yet expression
evaluation still doesn't work with ScalaTest. What is the status of this
PR? It this project still alive?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALEzS_ijA6c0GrWjA8wlBe9plYWZcgOVks5t59zagaJpZM4EqL2q>
.
|
|
We will revisit it. I am not sure why it didn't get pulled in. |
|
@cla-bot[bot] check |
|
Hi @wpopielarski, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you. |
|
The cla-bot has been summoned, and re-checked this pull request! |
currently the scalatest launcher uses standard java vm runner
to run or debug tests. It works fine with a java expression
evaluator but with the Scala IDE 4.1.0 there is available the
Scala Expression Evaluator which requires a Scala Debugger.
This enhancement adds a new scala launcher. From now it is
possible to choose appropriate launcher:
with scalatest. Then debugging and evaluation can be done with a java
evaluator
well but is not documented).
You can stop in breakpoint during a test execution and evaluate
arbitrary expression.
This PR must be taken with scala-ide PR #955
Fix #52