Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running tests if the code hasn't successfully recompiled #59

Open
lukeu opened this issue Mar 21, 2016 · 0 comments
Open

Avoid running tests if the code hasn't successfully recompiled #59

lukeu opened this issue Mar 21, 2016 · 0 comments

Comments

@lukeu
Copy link

lukeu commented Mar 21, 2016

Suggestion: would it be possible to halt (or warn) before starting a ScalaTest when there is a compile error* which invalidates the test? Right now, it appears to runs the stale previously-successful build and hence can report that all tests are successful, which I find misleading.

"But why are you running tests when the build failed to compile!?!", you might ask. Good question. :-) Well firstly, sometimes the icon in the "Problems" view is going to show a red cross anyway, for example if I know that there is some error in some other package that doesn't affect the test I'm running. Eclipse is nice like that, in that it doesn't dictate the order in which you deal with things. So this behaviour would mean sometimes having to scroll around the problems view to be sure there's no relevant compile error.

Also there's the fact that I have been engrained by JUnit to believe that I can trust it's green light icon to mean "all is well". So perhaps this is an argument itself just on grounds of UI consistency?

Anyway, this seems like a minor thing, but I've certainly bitten myself by it a number of times. For example, discovering part way through a git-rebase that the last 4 commits where I've fixed conflicts & tested are actually invalid and I need to start over...

(*by "compile error" I suppose I mean something in the Problems view, not a presentation-compiler error which often seems to include transient / false errors.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant