Closing a connection with "usageCount > 1" is possible.

[rankinc]

JdbcPooledConnection.close() says:

    // this should never happen, should we throw an exception or log at warn/error?
    if (usageCount > 0) {
        log.warn("close connection with usage count > 0, " + this);
    }

However, should JdbcPooledConnection.getConnectionHandle() throw a SQLException because (e.g.) testConnection() has failed, then usageCount will still have been incremented when XAPool.getConnectionHandle() tries to close the invalid connection.

The patch is trivial:

// Increment the usage count
usageCount++
try {

   // etc

} catch (SQLException e) {
    // This connection must be invalid, so revert the usage counter.
    // Note: Closing a handle with usageCount > 0 "should never happen".
    --usageCount;
    throw e;
}

Cheers,
Chris

[rankinc]

I've committed this change into my BTM tree on github, but cannot see how to create a new pull request that doesn't also include my existing and outstanding pull request #15.

[vladmihalcea]

Hi Chris,

I ran into the same issues, so I decided to write a guide for Git feature branching for the Bitronix project:

http://vladmihalcea.com/2014/02/13/a-beginners-guide-to-git-feature-branches/

I hope it will be one day incorporated in the README section.

Vlad

[rankinc]

Hi Vlad,
Thanks, I think that a "feature branch" is well worth using for future pull requests. However, seeing as I was actively asked to create #15, I don't think that it's unreasonable to hope that it be merged first.

Cheers,
Chris

[rankinc]

Closed, and replaced with #21.