improvement: thresholds for folding regions #7013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't merge region with parent when if parent too small without it - allow to configure folding region threshold using server properties - make threshold work consistently
tgodzik
reviewed
Dec 9, 2024
| @@ -41,13 +42,13 @@ String hello(String str) >>region>>{ | |||
| return "asssd"; | |||
| }<<region<< | |||
|
|
|||
| void openingCommentInStr() >>region>>{ | |||
There was a problem hiding this comment.
Why did we lose a region here? That should be 3 lines with all the {}
Same below
There was a problem hiding this comment.
I counted only the lines that actually get folded, so:
def a = {
1
}is one
def a =
1is also one. Think it's a bit more intuitive than if these had two and one respectively. I can offset by one, so both count as 2, would that be better?
There was a problem hiding this comment.
ok, let's try this solution. I don't really have preference and it looks sensible. Thanks for explaining!
| val t = | ||
| 1 + 2 | ||
|
|
||
| t match |
There was a problem hiding this comment.
We should have a region for match as weel
| @@ -7,14 +7,14 @@ class A >>region>>{ | |||
| }<<region<< | |||
|
|
|||
| def noSpacing =>>region>> | |||
| for>>region>>{ | |||
There was a problem hiding this comment.
We should still have this region as well, no?
|
Thanks! This seems great ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #6938