Lsp progress notofication leaks

[kurnevsky]

Describe the bug

Metals doesn't always send "kind": "end" for $/progress notification which results in a leak in emacs:

E.g. here I had a notification without an end (this is the last notification with this token):

[Trace - 12:32:56 PM] Received notification '$/progress'.
Params: {
  "token": "783ead62-37f8-4951-9d13-c0e457af51cf",
  "value": {
    "kind": "report",
    "message": "4s (100%)",
    "percentage": 100
  }
}

Also it seems it can get stuck infinitely reporting 0% progress (looks like when there was a compilation error):

[Trace - 12:36:00 PM] Received notification '$/progress'.
Params: {
  "token": "33705175-ff86-4eb7-9e4a-f22fb0fd2569",
  "value": {
    "kind": "report",
    "message": "3m4s (0%)",
    "percentage": 0
  }
}

Expected behavior

No response

Operating system

None

Editor/Extension

Emacs (lsp-metals)

Version of Metals

v1.4.0

Extra context or search terms

No response

[tgodzik]

Thanks for reporting! I hoped I fixed that 🤔 I will have to add some more logs to debug. It should send end for all tasks that have finished, not sure where it might get lost. I might need to more safeguards there.

[kurnevsky]

Might be related with this warning I constantly get now with the only option to open doctor: