Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using -test suffix for autogenerated test configuration is not a good idea. #62

Open
mnd999 opened this issue Aug 22, 2023 · 2 comments

Comments

@mnd999
Copy link
Contributor

mnd999 commented Aug 22, 2023

Describe the bug

Say we have a Maven project with two modules, module and module-test. Assume they both have code under src/test/scala and src/main/scala.

The generated bloop config for the code under module/src/test/scala will conflict with the one for module-test/src/main/scala because test code gets an autogenerated -test suffix and code under main does not get any suffix.

Either we should use a less commonly used suffix for test modules, or we should append a suffix (e.g. -compile) for both.

Expected behavior

Config under .bloop should be generated for all 4 compilation units. Instead we only get 3 as one overwrites the other.

Operating system

Linux

Version of Maven

6.4.10-arch1-1

Version of bloop-maven-plugin

1.5.4

Version of Bloop

Didn't get that far

@ckipp01
Copy link
Member

ckipp01 commented Sep 18, 2023

So this would probably need to change not just in the plugin, but also the entire bloop ecosystem, which might have some larger ramifications. @tgodzik, has this come up before?

@tgodzik
Copy link
Contributor

tgodzik commented Sep 18, 2023

I don't think it popped up before, but it's not a huge change, different build tools generate different module names. We would need to find conflicts and maybe add a fallback name in that case. Like module-test-scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants