New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The most infamous flaky test #840

Open

som-snytt opened this issue Apr 24, 2023 · 5 comments · May be fixed by scala/scala#10867

som-snytt commented Apr 24, 2023

scala/scala#10105 (comment)

presentation/doc sees Unexpected foo method comment: None.

Personally, I am surprised that foo requires comment.

Parking it here as internal.

The text was updated successfully, but these errors were encountered:

Author

som-snytt commented Apr 17, 2024

scala/scala#10732 (comment)

and

scala/scala#10732 (comment)

Member

lrytz commented Aug 20, 2024

i saw it locally 👻

Author

som-snytt commented Aug 22, 2024 •

edited

Loading

Duplicates #72 !

I corrected the title.

som-snytt changed the title ~~The less famous flaky test~~ The most infamous flaky test

Member

lrytz commented Aug 23, 2024

Looking at the code, the None probably originates here: https://github.com/scala/scala/blob/2d9e6acce8c4246e6cba5a22ff9d965ec3bd117c/src/interactive/scala/tools/nsc/interactive/Response.scala#L68

response.get is called here https://github.com/scala/scala/blob/53e1571071bf75ce6ddd6e7b4f0b84ef1bdc32f8/test/files/presentation/doc/doc.scala#L65

som-snytt linked a pull request

that will close this issue

PC invalidates previous work on new run scala/scala#10867

Draft

Author

som-snytt commented Sep 20, 2024

Sometimes I have a hankering for a large plate of spaghetti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment