Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play.mvc.Http.Context.Implicit._ to default imports #257

Open
ghost opened this issue Nov 16, 2015 · 4 comments
Open

Add play.mvc.Http.Context.Implicit._ to default imports #257

ghost opened this issue Nov 16, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 16, 2015

Hi,

the play! framework includes the following as default import for the html templates:
play.mvc.Http.Context.Implicit._

If someone agrees with me, I will add it to the default imports in the plugin and raise the pull request.

Thank you,
Guido

@kiritsuku
Copy link
Member

What is the issue? Is this default import missing for the presentation compiler but not for the builder (i.e. one sees errors in the editor but the code compiles fine)?

@ghost
Copy link
Author

ghost commented Nov 17, 2015

Yes, the template editor doesn't find ctx(), session() or flash(), but when compiling and running there are no actual errors.

It should be an easy one-line change, I would be glad to contribute in this case!

@kiritsuku
Copy link
Member

If you want to fix this please go ahead. Contributions welcome!

kiritsuku referenced this issue Nov 24, 2015
…it-to-default-imports-#257

Added play.mvc.Http.Context.Implicit._ to default template imports
@oxc
Copy link

oxc commented Apr 18, 2016

I believe this was fixed in 4d42503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants