Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Play tutorial for Play 2.1 and Scala IDE 3.0.0 #54

Merged
merged 2 commits into from
Apr 3, 2013

Conversation

dotta
Copy link
Member

@dotta dotta commented Mar 27, 2013

  • I've removed the French translation because I don't really feel like
    maintaining it. That being said, it's easy to bring it back to life.
    (@skyluc, please, don't take offense for this, and feel free to update
    the French tutorial. In the meanwhile, I think it's valuable to have
    the updated English tutorial out asap).
  • I have only updated the text, not the images, as this is cumbersome and
    I think having un up-to-date text is sufficient to understand the tutorial.

Fixes #53

@huitseeker
Copy link
Member

Would it be hard to re-organize this PR, so that the french version removal and the update Play 2.0 -> Play 2.1 are separate commits ? If we want to maintain the french version in the future, it will make starting with what we aleready had with Play 2.0 MUCH easier (by simply reverting the deletion commit).

@dotta
Copy link
Member Author

dotta commented Apr 2, 2013

If that's what it takes to get this merged, I can do it. @skyluc are you ok with that?

@huitseeker
Copy link
Member

This has a LGTM as soon as we have two separate, well-delineated commits between the French removal and 2.1 update

@dotta
Copy link
Member Author

dotta commented Apr 2, 2013

@skyluc ping :) I just want to know if I should waste time in splitting commits, or if you plan on updating the French version in time for the release.

Actually, after further thinking, it makes sense to split the commits either ways. So, I'm doing it. Sorry for the noise.

I've removed the French translation of the Play2 tutorial because I don't
really feel like maintaining it. That being said, it's easy to bring it back to
life.

(@skyluc, please, don't take offense for this, and feel free to update the
French tutorial.)
@dotta
Copy link
Member Author

dotta commented Apr 3, 2013

@huitseeker I've splitted my changes into two meaningful commits. I think this should be good to be merged now.

@huitseeker
Copy link
Member

LGTM!

I have only updated the text, not the images, as this is cumbersome and
I think having un up-to-date text is sufficient to understand the tutorial.

Fixes #53
dotta added a commit that referenced this pull request Apr 3, 2013
Updated Play tutorial for Play 2.1 and Scala IDE 3.0.0
@dotta dotta merged commit 3690d8b into master Apr 3, 2013
@dotta dotta deleted the issue/update-play-tutorial-53 branch April 3, 2013 14:56
dotta added a commit that referenced this pull request Apr 3, 2013
Please don't merge this for the moment becuase the image is not yet available.
I'll fix it as soon as we stage the Play2 plug-in.

Fix #54
dotta added a commit that referenced this pull request Apr 5, 2013
Please don't merge this for the moment becuase the image is not yet available.
I'll fix it as soon as we stage the Play2 plug-in.

Fix #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Play tutorial to the latest Play 2.1 release
2 participants