-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Play tutorial for Play 2.1 and Scala IDE 3.0.0 #54
Conversation
Would it be hard to re-organize this PR, so that the french version removal and the update Play 2.0 -> Play 2.1 are separate commits ? If we want to maintain the french version in the future, it will make starting with what we aleready had with Play 2.0 MUCH easier (by simply reverting the deletion commit). |
If that's what it takes to get this merged, I can do it. @skyluc are you ok with that? |
This has a LGTM as soon as we have two separate, well-delineated commits between the French removal and 2.1 update |
@skyluc Actually, after further thinking, it makes sense to split the commits either ways. So, I'm doing it. Sorry for the noise. |
I've removed the French translation of the Play2 tutorial because I don't really feel like maintaining it. That being said, it's easy to bring it back to life. (@skyluc, please, don't take offense for this, and feel free to update the French tutorial.)
@huitseeker I've splitted my changes into two meaningful commits. I think this should be good to be merged now. |
LGTM! |
I have only updated the text, not the images, as this is cumbersome and I think having un up-to-date text is sufficient to understand the tutorial. Fixes #53
Updated Play tutorial for Play 2.1 and Scala IDE 3.0.0
Please don't merge this for the moment becuase the image is not yet available. I'll fix it as soon as we stage the Play2 plug-in. Fix #54
Please don't merge this for the moment becuase the image is not yet available. I'll fix it as soon as we stage the Play2 plug-in. Fix #54
maintaining it. That being said, it's easy to bring it back to life.
(@skyluc, please, don't take offense for this, and feel free to update
the French tutorial. In the meanwhile, I think it's valuable to have
the updated English tutorial out asap).
I think having un up-to-date text is sufficient to understand the tutorial.
Fixes #53