Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded colors #991

Merged
merged 12 commits into from
Nov 22, 2024
Merged

Remove hardcoded colors #991

merged 12 commits into from
Nov 22, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Nov 20, 2024

Description

Removed hardcoded colors so colors will be better for extensions.

Changes:

general:

  • copy button near address and transactions is the same color as default text
  • changed input content and placeholder colors
  • switch theme toggle color is now text-base-content, so it has the same color as switch icon, has better contrast and also is better for extensions, for example sre-challenges light theme
  • changed balance error border color
  • changed receipt object keys colors

debug page:

  • display variable is now text-base-content/80 and also normal font-weight so it has better contrast with var title

blockexplorer:

  • changed color of searchbar placeholder
  • changed hardcoded color of pagination button to btn-disabled

Additional Information

Copy link
Contributor

@portdeveloper portdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropped one little nitpicky comment, other than that, it looks good to me!

packages/nextjs/components/SwitchTheme.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rinat this is great!! Just added a couple of small comments

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @rin-st ! Looks good to me 🙌

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm @rin-st 🙏!

@technophile-04 technophile-04 merged commit 05f46c8 into main Nov 22, 2024
1 check passed
@technophile-04 technophile-04 deleted the remove-hardcoded-colors branch November 22, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants