-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded colors #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just dropped one little nitpicky comment, other than that, it looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rinat this is great!! Just added a couple of small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @rin-st ! Looks good to me 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm @rin-st 🙏!
Description
Removed hardcoded colors so colors will be better for extensions.
Changes:
general:
text-base-content
, so it has the same color as switch icon, has better contrast and also is better for extensions, for example sre-challenges light themedebug page:
text-base-content/80
and also normal font-weight so it has better contrast with var titleblockexplorer:
btn-disabled
Additional Information