Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up db columns #366

Open
wilbertom opened this issue May 10, 2014 · 4 comments
Open

Clean up db columns #366

wilbertom opened this issue May 10, 2014 · 4 comments
Labels

Comments

@wilbertom
Copy link
Member

Set lengths on Unicode columns, make sure all columns which can't be null, can't be null. Replace SQLite3 and apply the database migration.

@wilbertom
Copy link
Member Author

Paging @nwinklareth @bepetersn, what is a ChargesDescription's description column? Is it what we called a charges

@nwinklareth
Copy link
Contributor

"Driving with a suspended license"

That is an example of a description.

As to the length, run this query on the database:

select charges from countyapi_chargeshistory
where length(charges ) =
( select max(length(charges )) from countyapi_chargeshistory)

then sun up to the next power of 2 and use that as the length of field, I
would use varchar or the unicode equivalent, fixed length field will waste
a lot of space

On Mon, May 12, 2014 at 5:36 PM, Wilberto Morales
[email protected]:

Paging @nwinklareth https://github.com/nwinklareth @bepetersnhttps://github.com/bepetersn,
what is a ChargesDescription's description column?


Reply to this email directly or view it on GitHubhttps://github.com//issues/366#issuecomment-42897333
.

Regards

Norbert

Norbert Winklareth

@bepetersn
Copy link
Member

@wilbertom, does this still need work?

@wilbertom
Copy link
Member Author

Yup still needs a lot with columns sizes, and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants